Skip to content

fix(config): close resource streams - #7002

Merged
kuny0707 merged 4 commits into
tronprotocol:release_v4.8.3from
Federico2014:fix/resource-streams-v4.8.3
Oct 11, 2026
Merged

kuny0707 merged 4 commits into
tronprotocol:release_v4.8.3from
Federico2014:fix/resource-streams-v4.8.3

Conversation

@Federico2014

Copy link
Copy Markdown
Collaborator

What does this PR do?

Closes streams used for Git metadata and zk parameter loading, avoids opening a stream just to locate configuration resources, and closes directory-walk streams in plugin copy utilities and affected tests. Missing zk parameter resources now produce an explicit error.

Why are these changes required?

Unclosed streams can retain file or directory handles during repeated operations and cause resource exhaustion or platform-dependent failures.

This PR has been tested by:

  • 62 focused Framework and Plugins tests passed on macOS x86_64 with JDK 8.
  • Framework main/test and Plugins main Checkstyle passed.

Follow up

None.

Extra details

None

Port the remaining changes from #48 (9bbf15f).

Skip GetTransactionByIdSolidityServletTest because release_v4.8.3 replaced its file-backed response handling in 0d19485. Preserve the updated BroadcastServletTest error-response assertion.
Comment thread plugins/src/main/java/common/org/tron/plugins/utils/FileUtils.java Outdated
Comment thread framework/src/main/java/org/tron/core/zen/ZksnarkInitService.java Outdated

@halibobo1205 halibobo1205 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kuny0707
kuny0707 merged commit 1575c4f into tronprotocol:release_v4.8.3 Oct 11, 2026
9 of 10 checks passed
Little-Peony added a commit to Little-Peony/java-tron that referenced this pull request Oct 12, 2026
* release_v4.8.3:
  feat(framework): remove --keystore-factory support from FullNode (tronprotocol#6978)
  refactor(proto): remove unused proto discover definition (tronprotocol#7014)
  fix(config): close resource streams (tronprotocol#7002)
  refactor(crypto): remove unused SM2 and SM3 (tronprotocol#6999)
  feat(plugins): backfill section bloom (tronprotocol#6973)
  refactor(api): remove dead WalletExtension gRPC service and config (tronprotocol#6975)
  refactor(framework): decouple Manager from TronJsonRpcImpl (tronprotocol#6990)
  refactor(api): replace response copy wrappers with Jetty content count (tronprotocol#6982)
  update a new version. version name:GreatVoyage-v4.8.2.2-1-gf3e81404fe,version code:18830 (tronprotocol#7008)
  feat: improve node stability and execution efficiency (tronprotocol#7007)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants